Fix: Note title sometimes missing characters in note list #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
A user reported an issue (2932709-zen) that's been present for months, where sometimes edits to the note title aren't properly reflected in the notes list, usually missing the last character.
In my testing this was inconsistent but usually easy to trigger within about 30 seconds of rapid typing/deleting in the note title and eliminating the caching for the note excerpt fixed it. At @dmsnell's suggestion this PR switches to using
contentrather thanmodificationDateas the cache key. For me this seems to completely eliminate the problem.Test
Release
Not updated: Fixed a bug causing the note title to sometimes be missing characters in the note list