Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react tabs types #2096

Merged
merged 1 commit into from
May 28, 2020
Merged

Add react tabs types #2096

merged 1 commit into from
May 28, 2020

Conversation

belcherj
Copy link
Contributor

Adds types for react-tabs npm module.

@belcherj belcherj requested a review from a team May 18, 2020 02:34
@belcherj belcherj self-assigned this May 18, 2020
codebykat
codebykat reviewed May 20, 2020
View reviewed changes
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but I don't know what it does? Is there any more context?

@belcherj
Copy link
Contributor Author

It adds the type definitions for react-tabs so Typescript knows how to handle the module. https://github.com/DefinitelyTyped/DefinitelyTyped

@codebykat codebykat self-requested a review May 21, 2020 16:19
@belcherj belcherj force-pushed the types/react-tabs branch from 11ebd54 to b602383 Compare May 28, 2020 09:13
@belcherj belcherj merged commit efd4835 into develop May 28, 2020
@belcherj belcherj deleted the types/react-tabs branch May 28, 2020 09:39
@codebykat codebykat added this to the 1.18 milestone Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebykat codebykat codebykat approved these changes

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
1.18
Development

Successfully merging this pull request may close these issues.
2 participants
@belcherj @codebykat