Note List: Refactor selection, stop selecting notes #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
belcherj
force-pushed
the
refactor/note-list-selection
branch
from
9521ad0 to
f021744
Compare
codebykat
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
This is actually testing out really well for me now! I did a bunch of stuff quickly with both web and Electron open and the selection was behaving correctly. Didn't see noteflip (of course I almost never see it anyway so something about "absence of evidence"). Still a lag after creating a new note and before it gets selected but that's not new or a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This changes the selection logic to stop notes being unselected unintentionally.
Some discussion here: #2120
Test
Release
Fixed bug where notes could be unintentionally unselected.