Fix: Ability to log in with mixed case email address #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dmsnell
reviewed
Jul 23, 2020
dmsnell
reviewed
Jul 23, 2020
dmsnell
reviewed
Jul 23, 2020
dmsnell
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Thanks @codebykat - at some point we should be able to do as you suggest and move this to the backend, I think/hope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This issue only arises in the Electron apps because App Engine authentication lowercases these arguments before creating or logging in to an account.
I also added a trim to match the App Engine logic.
Fixes #2193
Test
Release
Not updated: Fixed a bug that prevented login if capital letters were typed in the email address