Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Note list when using search #2340

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Open Note list when using search #2340

merged 2 commits into from
Sep 22, 2020

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Sep 22, 2020 •
edited
Loading

Fix

Fixes: #728

When in a narrow mode if you use the search hotkey it does not open the note list. I am not sure what the UI should be.

What do you think @SylvesterWilmott ?

Existing Functionality:
existing

This PR:
thispr

Test

  1. Have a narrow browser
  2. Have a note open
  3. Use the hotkey CMD + F

@belcherj belcherj self-assigned this Sep 22, 2020
@codebykat codebykat self-requested a review September 22, 2020 03:42
codebykat
codebykat approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior feels right to me and the code change looks good 👍

@belcherj belcherj force-pushed the update/open-notelist-on-search branch from 34bc4af to 402f768 Compare September 22, 2020 12:00
@SylvesterWilmott
Copy link
Contributor

This behavior feels right to me and the code change looks good 👍

Agreed. Looks good, thanks @belcherj

@belcherj belcherj merged commit 398c2b2 into develop Sep 22, 2020
@belcherj belcherj deleted the update/open-notelist-on-search branch September 22, 2020 23:29
@codebykat codebykat added this to the 2.0.0 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebykat codebykat codebykat approved these changes

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Show the sidebar when doing a global search in a narrow window.
3 participants
@belcherj @SylvesterWilmott @codebykat