Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #2356

Closed
wants to merge 5 commits into from
Closed

Update Dependencies #2356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01816bf
Update Dependencies
belcherj Sep 22, 2020
1839216
pass an empty handler to keybinding service to avoid an error
codebykat Sep 30, 2020
2b073f6
remove clipboard types from production deps
codebykat Sep 30, 2020
d823e7c
Update package-lock.json
belcherj Nov 11, 2020
4e63bab
Fix regenerator runtime issue
belcherj Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ module.exports = function (api) {
{
corejs: '3',
useBuiltIns: 'entry',
targets: {
esmodules: true,
},
},
],
'@babel/preset-react',
Expand All @@ -17,6 +20,7 @@ module.exports = function (api) {
'@babel/plugin-proposal-object-rest-spread',
'@babel/plugin-proposal-optional-chaining',
'@babel/plugin-syntax-dynamic-import',
'@babel/plugin-transform-runtime',
];
const env = {
development: {
Expand Down
13 changes: 7 additions & 6 deletions lib/app-layout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,17 @@ import * as selectors from '../state/selectors';
import * as S from '../state';
import * as T from '../types';

const NoteList = React.lazy(() =>
import(/* webpackChunkName: 'note-list' */ '../note-list')
const NoteList = React.lazy(
() => import(/* webpackChunkName: 'note-list' */ '../note-list')
);

const NoteEditor = React.lazy(() =>
import(/* webpackChunkName: 'note-editor' */ '../note-editor')
const NoteEditor = React.lazy(
() => import(/* webpackChunkName: 'note-editor' */ '../note-editor')
);

const NotePreview = React.lazy(() =>
import(/* webpackChunkName: 'note-preview' */ '../components/note-preview')
const NotePreview = React.lazy(
() =>
import(/* webpackChunkName: 'note-preview' */ '../components/note-preview')
);

type StateProps = {
Expand Down
3 changes: 0 additions & 3 deletions lib/boot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import 'core-js/stable';
import 'regenerator-runtime/runtime';

import './utils/ensure-platform-support';

import { parse } from 'cookie';
Expand Down
4 changes: 2 additions & 2 deletions lib/dialogs/import/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import { closeDialog } from '../../state/ui/actions';

import * as S from '../../state';

const SourceImporter = React.lazy(() =>
import(/* webpackChunkName: 'source-importer' */ './source-importer')
const SourceImporter = React.lazy(
() => import(/* webpackChunkName: 'source-importer' */ './source-importer')
);

type DispatchProps = {
Expand Down
6 changes: 5 additions & 1 deletion lib/note-content-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,11 @@ class NoteContentEditor extends Component<Props> {
shortcutsToDisable.push('undo', 'redo', 'editor.action.selectAll');
}
shortcutsToDisable.forEach(function (action) {
editor._standaloneKeybindingService.addDynamicKeybinding('-' + action);
editor._standaloneKeybindingService.addDynamicKeybinding(
'-' + action, // commandID
null, // keybinding
() => {} // need to pass an empty handler
);
});

// disable editor keybindings for Electron since it is handled by editorCommand
Expand Down
Loading