Electron: Handle all keyboard shortcuts that are in the menu, from the menu #2370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
When we add menu items in Electron we're passing a keyboard shortcut, but we were clobbering those with our keyboard event listeners in the app. This causes them to fire and be handled without the Electron menu flashing, which makes things feel kind of janky and breaks the illusion of a native app.
This also fixes the missing handler for Find Note, although it does the exact same thing as Search in Notes, so it's kind of odd to have them both in the menu?
Test
a) they can be triggered by clicking in the menu
b) triggering them by keyboard shortcut causes the menu to flash