When there are no notes suggest creating one

[belcherj]

Fix

When a user does not have any notes suggest adding a new note. Additionally, if a user types a search term that does not match any notes suggest creating a new not with that query.

This also fixes a bug where if you have no notes "Notes Loading" neve disappears.

Test

1. Have no notes, observe note list suggests you add a new note
2. Have a search query that does not match any notes. Observe note list suggest that you create one with that search term

Release

Suggest creating a new note when none exists or notes match search query.

[iamthomasbishop]

Looks pretty good at first glance @belcherj, I like this type of suggestion/tip on search. I'm not 100% familiar with y'all's color palette in light vs. dark mode, so I'll leave that to @SylvesterWilmott , but the messaging and placement makes sense to me. A couple of suggestions — both very minor, subjective, and to be taken with a grain of salt:

• Feel free to overrule me if there's an established rule/guideline here, but the text for the "create a new note" button feels rather large to me. Perhaps a "secondary" label size that's just a tad smaller would feel less so?

• I also think it'd benefit from a slight bit of margin between it and the "no results" label. I'm not sure what spacing/grid you're using if any, but just a small unit of margin — something like 8px of margin if on an 8px grid — would probably be enough.

Obviously very minor things, and if established rules should negate either, feel free to bypass 😄

[belcherj]

@iamthomasbishop I made the text smaller and added padding between the button and the text.

[iamthomasbishop]

@belcherj nice, thanks!

Is it just my eyes, or is the blue color being used for the icons in the top toolbar different from the button text below in dark mode? Light mode seems about right but it's hard to tell for sure. Screenshot:

[codebykat]

Code looks good, tests good. 👍

We definitely need to focus the text within the editor after creating the new note, so you can create a new note and immediately continue typing.

Also, should we consider clearing the search query after the new note is created? Right now you end up here, which is kind of a lot of highlighting:

[belcherj]

We are now focusing the editor when changing notes and creating a new note. (1281ee9)

#2434 will clear the search when a new note is created.

[SylvesterWilmott]

Feel free to overrule me if there's an established rule/guideline here, but the text for the "create a new note" button feels rather large to me. Perhaps a "secondary" label size that's just a tad smaller would feel less so?

That is correct, the label size here should 14px based on the design found in Zeplin. @belcherj can we make sure we update this?

[belcherj]

Done