Fix: Load configured app_id when connecting to Simperium
#2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the big rewrite I accidentally instructed the Simperium middleware to always connect to the production Simperium application and overlook what might be configured in the `config.json` or `config-local.json` files. This led to people being unable to sign in to test accounts on the test backend: the successful authorizatio would lead to the app immediately signing out due to an `Token Invalid` over the WebSocket. With this fix we're using the configured app name, reading it from the configs, so that when the repo is cloned and ran it properly connects to `history-analyst-dad` (or any value set in its place). This fix restores one's ability to sign in. Props to @tbourrely for valuable diagnosis of this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2396
In the big rewrite I accidentally instructed the Simperium middleware to always connect
to the production Simperium application and overlook what might be configured in the
config.jsonorconfig-local.jsonfiles. This led to people being unable to sign into test accounts on the test backend: the successful authorizatio would lead to the app
immediately signing out due to an
Token Invalidover the WebSocket.With this fix we're using the configured app name, reading it from the configs, so that
when the repo is cloned and ran it properly connects to
history-analyst-dad(or anyvalue set in its place). This fix restores one's ability to sign in.
Props to @tbourrely for valuable diagnosis of this issue in #2396