Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add arguments to addDynamicKeybinding #2546

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

codebykat
Copy link
Member

Fix

In upcoming Monaco versions we will need to add these arguments to avoid a crash. We can't update Monaco yet but we can update this so it won't break whenever we do.

It looks like this will become an issue starting in monaco-editor 0.21.0.

See microsoft/monaco-editor#2157 (comment)

Test

  1. Test keybindings in browser and Electron
  2. Verify they still work as expected and none of the default Monaco behaviors are still present

Release

Future-proof a function call to the keybinding service

@codebykat codebykat added this to the 2.5.0 milestone Jan 5, 2021
@codebykat codebykat requested a review from a team January 5, 2021 08:54
@codebykat codebykat self-assigned this Jan 5, 2021
@nsakaimbo
Copy link

Smoke-tested the built app on Windows and things appear to be working as expected (including keyboard shortcuts).

Copy link

@nsakaimbo nsakaimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codebykat codebykat merged commit d130dfb into develop Jan 5, 2021
@codebykat codebykat deleted the update/futureproof-monaco-keybindings branch January 5, 2021 22:04
@codebykat codebykat mentioned this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants