Chore: add arguments to addDynamicKeybinding #2546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
In upcoming Monaco versions we will need to add these arguments to avoid a crash. We can't update Monaco yet but we can update this so it won't break whenever we do.
It looks like this will become an issue starting in monaco-editor 0.21.0.
See microsoft/monaco-editor#2157 (comment)
Test
Release
Future-proof a function call to the keybinding service