Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent adding undefined to className when value do not provided #2551

Merged
merged 4 commits into from
Jan 11, 2021
Merged

prevent adding undefined to className when value do not provided #2551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3f3ff7
update controls/checkbox
ubaidisaev Jan 6, 2021
f0b5f8d
update controls/toggle
ubaidisaev Jan 6, 2021
20249e9
Update index.tsx
ubaidisaev Jan 8, 2021
287f82a
Update index.tsx
ubaidisaev Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/controls/checkbox/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ type OwnProps = React.HTMLProps<HTMLInputElement> & {

function CheckboxControl({ className, ...props }: OwnProps) {
return (
<span className={classNames('checkbox-control', className)}>
<span className={classNames('checkbox-control', [className])}>
<input type="checkbox" {...props} />
<span className="checkbox-control-base">
<span className="checkbox-control-checked" />
Expand Down
3 changes: 2 additions & 1 deletion lib/controls/toggle/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, { ChangeEventHandler, FunctionComponent } from 'react';
import classNames from 'classnames';

type OwnProps = Partial<HTMLInputElement> & {
onChange: (isNowToggled: boolean) => any;
Expand All @@ -16,7 +17,7 @@ export const ToggleControl: FunctionComponent<Props> = ({
}) => onChange(checked);

return (
<span className={`toggle-control ${className}`}>
<span className={classNames('toggle-control', [className])}>
<input type="checkbox" onChange={onToggle} {...props} />
<span className="toggle-control-layers">
<span className="toggle-control-unchecked-color" />
Expand Down