-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new note icon to top toolbar when in focus mode #2596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! There's a teensy alignment issue on the Mac build (I think we're adding some extra toolbar padding for this platform):
I'm also wondering (and this is an honest question, not me being Socratic) if there's a way to use the same button in the note toolbar and in the menu bar, and use styles to change its placement... or even if those two menu bars should now be the same component. 🤔
Does that seem possible or too much of a pain?
Thanks for pointing me in the right direction with the padding @codebykat and catching that. I had tested on macOS and then made some changes and obviously didn't check closely again. I did take a quick look to see before I started to see if I could use that same button but didn't see a good way to do it. I didn't look at refactoring to make the menu bars one component though. I'll investigate that a bit. |
@codebykat I took a look at moving the two menus into one component. I think it could be done. It would likely make for a big component and refactor the layout of the app. I don't think it is something I could do as part of this PR, but would be happy to look at it more together at some point if you are up for it. |
083520f
to
fd4864a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great now, including on OSX 👍
[testing] fix/feature verified on Dell Latitude 7400 | Win 10 | Simplenote 2.7.0-beta1 |
Fix
Adding the new note icon to the note toolbar when we are in focus mode.
This addresses part of the issue #2563 as part of the UI Spring Cleaning.
Test
Release