Fix loading of the analytics preference so it will send events if user has opted in #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
reviewed
Jan 28, 2021
lib/state/simperium/middleware.ts
Outdated
| preferencesBucket.channel.once('ready', () => { | ||
| dispatch({ | ||
| type: 'REMOTE_ANALYTICS_UPDATE', | ||
| allowAnalytics: getState().data.analyticsAllowed, |
There was a problem hiding this comment.
I think here we want allowAnalytics: !!(await preferencesBucket.get('preferences-key'))?.analytics_enabled or whatever it takes to do that. maybe this works too and it won't matter much.
belcherj
changed the title
codebykat
approved these changes
Jan 28, 2021
codebykat
force-pushed
the
fix/analytics
branch
from
0e23db5 to
f4b2e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Ensure that we set the analyticsAllowed value on window when page loads and the preferences bucket is ready.
Test