Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the spellcheck option from edit menu on electron builds #2650

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Remove the spellcheck option from edit menu on electron builds #2650

merged 1 commit into from
Feb 10, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

This resolves #2648. In light of #2410 this menu item is confusing. Until we add back in spellcheck this removes the spellcheck option from the edit menu in the desktop apps.

Test

  1. On Windows and Linux install artifacts from this PR.
  2. Visit the Edit menu at the top.
  3. Ensure Spellcheck does not show.

Release

  • Remove the spellcheck option from the edit menu.

@sandymcfadden sandymcfadden added this to the 2.8.0 milestone Feb 10, 2021
@sandymcfadden sandymcfadden self-assigned this Feb 10, 2021
@sandymcfadden sandymcfadden requested a review from a team February 10, 2021 15:39
@sandymcfadden sandymcfadden marked this pull request as ready for review February 10, 2021 15:39
@sandymcfadden sandymcfadden merged commit 5506063 into develop Feb 10, 2021
@codebykat codebykat deleted the remove/spellcheck-menu-item branch February 11, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belcherj belcherj belcherj approved these changes

Assignees

@sandymcfadden sandymcfadden

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Remove Spell-checking option from Edit Menu
2 participants
@sandymcfadden @belcherj