Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: refresh note list after revision restored #2667

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Fix: refresh note list after revision restored #2667

merged 1 commit into from
Feb 16, 2021

Conversation

codebykat
Copy link
Member

Fix

Fixes #2664

Test

  1. Have an unpinned note
  2. Pin it
  3. Restore to prior version with History slider
  4. Note that it correctly moves in the notes list

Release

Fixed a bug where the notes list was not updated after restoring a revision

@codebykat codebykat added this to the 2.8.0 milestone Feb 11, 2021
@codebykat codebykat requested a review from a team February 11, 2021 21:38
@codebykat codebykat self-assigned this Feb 11, 2021
sandymcfadden
sandymcfadden approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@sandymcfadden sandymcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and tests well for me.

@codebykat codebykat merged commit 4688f88 into develop Feb 16, 2021
@codebykat codebykat deleted the fix/revision-restore-doesnt-resort-note-list branch February 16, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandymcfadden sandymcfadden sandymcfadden approved these changes

Assignees

@codebykat codebykat

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Unpinning note via history leaves unpinned note above pinned ones
2 participants
@codebykat @sandymcfadden