Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of colors used throughout the app #2872

Merged
merged 1 commit into from
May 1, 2021
Merged

Reduce the number of colors used throughout the app #2872

merged 1 commit into from
May 1, 2021

Conversation

sandymcfadden
Copy link
Contributor

@sandymcfadden sandymcfadden commented Apr 23, 2021 •
edited
Loading

Fix

As a starting point to update the way we specify and use colors throughout the app in CSS this starts by reducing the number we use.

This is a list of the replacements this does.

  • $studio-simplenote-blue-30 -> $studio-simplenote-blue-20
  • $studio-gray-60 -> $studio-gray-50
  • $studio-red-40 -> $studio-red-50
  • red -> $studio-red-50
  • $studio-blue-30 -> $studio-simplenote-blue-20
  • $studio-red-60 -> $studio-red-50
  • $studio-orange-30 -> $studio-orange-20
  • $studio-gray-40 -> $studio-gray-50

Todo

  • Edit tags handle is not visible when hovered in dark mode
    The above was updated to have the tag list hover color to match the navigation bar hover above it.

Test

  1. Smoke test in light and dark mode to ensure things still look good.

Release

  • Reduced the number of colors used throughout the project.

@sandymcfadden sandymcfadden added this to the 2.11.0 milestone Apr 23, 2021
@sandymcfadden sandymcfadden self-assigned this Apr 23, 2021
@sandymcfadden sandymcfadden requested review from a team and SylvesterWilmott April 24, 2021 00:17
@sandymcfadden sandymcfadden marked this pull request as ready for review April 24, 2021 00:17
SylvesterWilmott
SylvesterWilmott approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@SylvesterWilmott SylvesterWilmott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandymcfadden, feels good to get these aligned.

codebykat
codebykat approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and yay for CSS simplicity 👍

@sandymcfadden
Change all uses of color SNBlue30 to SNBlue20
31a53a0 
Update uses of gray-60 to gray-50
Update red-40 to red-50
Update blue-30 to SNBlue20
Update red-60 to red-50
Update use of color red to red-50
Fix a color to gray-50
Update alternative login overlay colors
Update tag suggestion text color from -gray-40 to -gray-50
Update hover color of tag list items
Update -orange-30 to -orange-20
@sandymcfadden sandymcfadden force-pushed the update/reduce-colors-used branch from 33c1dcc to 31a53a0 Compare May 1, 2021 11:55
@sandymcfadden sandymcfadden merged commit 70b123e into develop May 1, 2021
@sandymcfadden sandymcfadden deleted the update/reduce-colors-used branch May 1, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvesterWilmott SylvesterWilmott SylvesterWilmott approved these changes

@codebykat codebykat codebykat approved these changes

Assignees

@sandymcfadden sandymcfadden

Labels
[status] needs design review
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sandymcfadden @codebykat @SylvesterWilmott