Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update the deploy script and config file encryption #3195

Merged
merged 7 commits into from
May 14, 2024

Conversation

codebykat
Copy link
Member

@codebykat codebykat commented May 9, 2024

Fix

  1. We need npm build --legacy-peer-deps everywhere we were previously using --force or no arguments. This is required for the deploy script to succeed.
  2. vip/package.json needs to be upgraded due to a security flaw in express.js (see Bump express from 4.17.1 to 4.19.2 in /vip #3193)
  3. Also upgraded the VIP Go helper (release notes show no breaking changes)
  4. Add make commands to decrypt and encrypt the config file, and add info to the README, including the lack of support for community development at this time. These encrypt/decrypt commands are the ones we use on App Engine.
  5. Re-encrypt the config file with newer encryption (again, same command from App Engine)

Test

  • CircleCI builds should succeed with this config
  • make decrypt_conf should succeed and should create config-local.json with production secrets
  • npm run deploy development should succeed

@codebykat codebykat changed the title Build: add legacy-peer-deps option to deploy scripts Build: Update the deploy script and config file encryption May 13, 2024
@codebykat codebykat marked this pull request as ready for review May 13, 2024 20:03
@roundhill roundhill force-pushed the fix/add-legacy-peer-deps-in-deploy branch from 31e22b0 to 28c77d3 Compare May 13, 2024 20:55
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • CircleCI builds should succeed with this config ✅
  • make decrypt_conf should succeed and should create config-local.json with production secrets ✅
  • npm run deploy development should succeed ✅ (I think this worked, no Slack confirmation but does it not run for development deploys?)

@codebykat codebykat merged commit 5ea6263 into trunk May 14, 2024
6 checks passed
@codebykat codebykat deleted the fix/add-legacy-peer-deps-in-deploy branch May 14, 2024 19:57
@codebykat codebykat added this to the 2.22.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants