Fix: Prevent preview from crashing on email address #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running 2.22.0 beta and still has the issue? Please note this is not related to ANY email - JUST the email address of the logged in user. All other email addresses work fine. |
|
@jcamp Huh, I can't reproduce that... and there's no code that is doing anything to detect the email address of the logged in user. Does your email address happen to contain any unusual characters that might be causing the preview to crash? Also, can you confirm this is still happening on https://app.simplenote.com ? The website is running the latest version of the code, which includes this fix (the current version of the beta app may not have been rebuilt after this addition, as we've been working on the build process). |
|
Fixed now on latest Beta thanks.
Sent from Gmail Mobile
…On Thu, 6 Jun 2024 at 09:10, Kat Hagan ***@***.***> wrote:
@jcamp <https://github.com/jcamp> Huh, I can't reproduce that... and
there's no code that is doing anything to detect the email address of the
logged in user. Does your email address happen to contain any unusual
characters that might be causing the preview to crash? Also, can you
confirm this is still happening on https://app.simplenote.com ? The
website is running the latest version of the code, which includes this fix
(the current version of the beta app may not have been rebuilt after this
addition, as we've been working on the build process).
—
Reply to this email directly, view it on GitHub
<#3205 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABEEJ2SHI43N2WBGOE2NY3ZGAKPJAVCNFSM6AAAAABIN5D77SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJRGY3DSOBXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This PR fixes #3200. The crash was a missing polyfill for
Bufferthat was only causing a runtime crash when theisemailcode ran.Test
Release
Fixed a bug where an email address in a note would cause the preview to be blank.