Add Magic link login #3246
Merged
Add Magic link login #3246
+281
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might need to make sure we're sending |
roundhill
reviewed
Aug 27, 2024
|
|
||
| contextBridge.exposeInMainWorld('electron', electronAPI); | ||
|
|
||
| module.exports = { |
There was a problem hiding this comment.
Needed to change this to module.exports to avoid a fatal
jleandroperez
approved these changes
Aug 30, 2024
| this.setState({ authStatus: 'submitting' }, async () => { | ||
| try { | ||
| const response = await fetch( | ||
| 'https://app.simplenote.com/account/request-login', |
There was a problem hiding this comment.
Is it a regular practise to leave URLs like this one?
There was a problem hiding this comment.
Ehh probably not, I'll see if there's some globals or a config or something!
There was a problem hiding this comment.
Other urls were just hard code like that so I left these in!
All sorted! Thanks @jleandroperez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Adds the option to login via a link or code to the Electron apps.
Test
Release
Added the option to log in via "magic" link or code.