-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show placeholders when user has no notes #666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, this is beautiful! Great work.
Second, something feels odd about passing around hasNotes
everywhere. Do you think there's any chance we could have an easy time splitting off early (up in or around app.jsx
) where we could display either the normal view or the empty notes view?
What happens with keyboard shortcuts when no notes are present? Do we need to factor that in in any way?
I could probably fake it with a few divs. 🤔 I thought it would be nice to keep the editor toolbar at the top with the dividers, but I can certainly fake that too :) |
personally I wasn't sure how hard or easy it would be. would probably be nice to at least explore the idea and see because if it could be done I think it might end up as something we would rather have. if it's too much of a headache (and this would definitely seem plausible) then please do what is pragmatic. |
…r the placeholder styles.
@dmsnell I got it working mainly in |
To me that seems like a boon - the toolbar buttons are useless without a note to operate on 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sooo much better, plus I think this might solve another issue, which is odd lines missing when no notes are visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
it also looks awesome on Windows and Ubuntu. ! |
I had a go at adding placeholders to the notes list and note editor when there are no notes to show. I used the native macOS app as inspiration. The editor toolbar buttons are also disabled.
@drw158 have a look! I used
$gray
for the color, but maybe we should add a bit of opacity to it so it's not quite so bold?