Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show placeholders when user has no notes #666

Merged
merged 7 commits into from
Nov 16, 2017
Merged

Conversation

roundhill
Copy link
Contributor

@roundhill roundhill commented Nov 9, 2017

I had a go at adding placeholders to the notes list and note editor when there are no notes to show. I used the native macOS app as inspiration. The editor toolbar buttons are also disabled.

@drw158 have a look! I used $gray for the color, but maybe we should add a bit of opacity to it so it's not quite so bold?

screen shot 2017-11-09 at 3 24 29 pm

screen shot 2017-11-09 at 3 23 37 pm

Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, this is beautiful! Great work.

Second, something feels odd about passing around hasNotes everywhere. Do you think there's any chance we could have an easy time splitting off early (up in or around app.jsx) where we could display either the normal view or the empty notes view?

What happens with keyboard shortcuts when no notes are present? Do we need to factor that in in any way?

@roundhill
Copy link
Contributor Author

easy time splitting off early (up in or around app.jsx)

I could probably fake it with a few divs. 🤔 I thought it would be nice to keep the editor toolbar at the top with the dividers, but I can certainly fake that too :)

@dmsnell
Copy link
Member

dmsnell commented Nov 10, 2017

I thought it would be nice to keep the editor toolbar at the top with the dividers

personally I wasn't sure how hard or easy it would be. would probably be nice to at least explore the idea and see because if it could be done I think it might end up as something we would rather have. if it's too much of a headache (and this would definitely seem plausible) then please do what is pragmatic.

@roundhill
Copy link
Contributor Author

roundhill commented Nov 15, 2017

@dmsnell I got it working mainly in app.jsx. The only tradeoff was that you don't see the toolbar buttons at all now, but I think it works.

screen shot 2017-11-15 at 1 46 27 pm

@dmsnell
Copy link
Member

dmsnell commented Nov 15, 2017

The only tradeoff was that you don't see the toolbar buttons at all now, but I think it works.

To me that seems like a boon - the toolbar buttons are useless without a note to operate on 😉

Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sooo much better, plus I think this might solve another issue, which is odd lines missing when no notes are visible.

Copy link
Contributor

@rodrigoi rodrigoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment of the header is off when running inside the electron chrome.
screen shot 2017-11-15 at 20 27 50

@roundhill
Copy link
Contributor Author

roundhill commented Nov 15, 2017

  • Bug: You can't drag the placeholder toolbar to reposition the app when in electron.

@roundhill roundhill changed the title WIP: Show placeholders when user has no notes Show placeholders when user has no notes Nov 15, 2017
@roundhill
Copy link
Contributor Author

The alignment of the header is off when running inside the electron chrome.

Thanks @rodrigoi I updated it for the macOS version in
31bbdb2

@rodrigoi
Copy link
Contributor

it also looks awesome on Windows and Ubuntu. :shipit: !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants