Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Put “Bring All to Front” in proper menu #813

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

mirka
Copy link
Member

@mirka mirka commented Aug 30, 2018

There was an off-by-one error causing the “Bring All to Front” menu item to be in the wrong menu.

This fixes the misplacement, and removes the usage of array indices to avoid similar bugs.

Before:

screen shot 2018-08-30 at 22 22 14 screen shot 2018-08-30 at 22 22 18

After:

screen shot 2018-08-30 at 22 21 32 screen shot 2018-08-30 at 22 21 40

@roundhill
Copy link
Contributor

:shipit: Nice fix.

@mirka mirka merged commit 7c12e5c into master Sep 4, 2018
@mirka mirka deleted the fix/window-menu-item-mac branch September 4, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants