Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sidebar toggle button #881

Merged
merged 6 commits into from
Sep 28, 2018

Conversation

mirka
Copy link
Member

@mirka mirka commented Sep 25, 2018

Depends on #880

This adds a Sidebar toggle button that is effectively the Focus Mode toggle.

note-list-anim

The button is hidden when the window is narrow, since the view will already be in single-column:
screen shot 2018-09-26 at 1 53 25

UX concerns to think about:

  • Is the icon intuitive?
  • Is it confusing that we're invoking two different concepts to describe what is effectively the same thing? (i.e. Toggle Sidebar vs. Focus Mode)
  • Does its utility justify the added clutter?

We might think of something better if/when we redesign the toolbars, but I think this will suffice for now.

@roundhill
Copy link
Contributor

I think I like it. Do you think it'd be too weird to only show the icon when focus mode is enabled? There's a lot of buttons at the top with this addition and I'm wondering if it is too much clutter.

@mirka
Copy link
Member Author

mirka commented Sep 26, 2018

Do you think it'd be too weird to only show the icon when focus mode is enabled?

I considered that for a while, but the thing is, that button has to always be there in the web app anyway 😅

My impression is that the clutter problem should be dealt with from the note toolbar side first. I don't have an accurate picture of usage patterns yet, but if the Revisions and Share buttons are used infrequently enough they could be moved to the Info pane. (Just a thought!)

We could also consider adding some hierarchy to the button designs. For example, the New Note button should be the primary call-to-action, the Markdown Preview button should be a different class of button, etc.

@roundhill
Copy link
Contributor

OK, how about we roll with this for now and we'll iterate on it later?

@mirka
Copy link
Member Author

mirka commented Sep 27, 2018

@roundhill

One bug is that it shows the animation on startup of the app

I've resolved this by preventing the Focus Mode setting from being persisted across launches. I think this will be better UX because there are situations in which launching straight into Focus Mode would be disorienting (like when the note is empty). Also the state management will be much simpler this way.

Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mirka mirka merged commit be9f67a into chore/icon-button-refactor Sep 28, 2018
@mirka mirka deleted the enhancement/focus-mode-escape branch September 28, 2018 09:43
mirka added a commit that referenced this pull request Sep 28, 2018
* Refactor icon-button in note-toolbar

* Tweak icon-button disabled state

* Refactor icon-button in search-bar

* Refactor icon buttons in SearchBar and NoteToolbar (#880)

* Add Sidebar toggle button (#881)

* Add Sidebar toggle button

* Remove unnecessary min-width

* Animate NoteList (slide out, fade in)

* Animate NoteList variation (slide out, slide in)

* Don't persist Focus Mode setting

* Revert "Animate NoteList variation (slide out, slide in)"

This reverts commit 4dbda20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants