Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charlie/add sustainer icon #1556

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Charlie/add sustainer icon #1556

merged 10 commits into from
Mar 27, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

As a thank you to our sustainers we are offering them the option to set their app icon to an exclusive icon color. This PR adds that functionality. NOTE: this will only work with existing sustainers, and becoming a sustainer is removed in another PR. In a future PR will figure out how sustainers will continue having access to this option after sustainer is retired.

Settings Icon

Test

  1. Clean install of Simplenote. Log into a non sustainer account. Go to Tags > Settings and confirm that there is no row for enabling the sustainer app icon
  2. Go to SPSettingsViewController.swift. and add return true` to L.44 so that you appear to be a sustainer
  3. relaunch the app, return to the settings view and confirm that you have a switch under the Sustainer Thank you section
  4. Enable the switch. Then exit the app and confirm the icon is now the pretty green color
  5. Relaunch the app, return to the settings and confirm that the sustainer app icon is enabled.

Review

(Required) Add instructions for reviewers. For example:

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in d3adb3ef with:

Added markdown support

If the changes should not be included in release notes, add a statement to this section. For example:

These changes do not require release notes.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 26, 2024

You can test the changes in simplenote-ios from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1556-b067188-018e80d5-332f-4393-83da-493571c4fddf on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from charlie/drop-sustainer to trunk March 26, 2024 22:11
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple notes, code wise looks great!!

:shipit: when ready!!

@charliescheer charliescheer merged commit b4f1af6 into trunk Mar 27, 2024
10 checks passed
@charliescheer charliescheer deleted the charlie/add-sustainer-icon branch March 27, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants