Convert dependency check annotation from h3 to p
#1663
Conversation
An `h3` (`###` markdown) in the CI annotation results in a message that clashes visually with the rest of the annotations. See for example https://buildkite.com/automattic/simplenote-ios/builds/1146
mokagio
added
the
tooling
| buildkite_annotate(context: 'pods-check', style: style, message: message) if is_ci | ||
| return unless is_ci | ||
|
|
||
| all_dependencies_stable = result[:pods].nil? || result[:pods].empty? |
There was a problem hiding this comment.
I did this tidy because I thought I'd add an emoji an wanted to DRY the check.
I decided not to add the emoji to the text because Buildkite already has icons and colors for each annotation style. But I kept the code like this because I think it's a tiny readability improvements.
Also, since I'm on my way to write more commentary than code, I considered being explicit in the variable names and the message in mentioning CocoaPods. But, I'd say leaving it as generic "dependencies" makes it easier for us to update the logic to incorporate something that parses the Package.resolved JSON looking for dependencies that point to non stable versions.
|
| App Name |  Simplenote Prototype Build |
|
| Build Number | pr1663-227c949-0192d743-03c8-48af-92a7-ab5031f7d876 | |
| Version | 4.54 | |
| Bundle ID | com.codality.NotationalFlow.Alpha | |
| Commit | 227c949 | |
| App Center Build | Simplenote - Installable Builds #391 |
The `ios_check_beta_deps` action doesn't discriminated between internal (1st party) and external (3rd party) dependencies. https://github.com/wordpress-mobile/release-toolkit/blob/ee03eb9232597fd812c18d3fb0fbf91130facf97/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_check_beta_deps.rb
Done, can be verified in the scenario for 4.56 and later. |
An
h3(###markdown) in the CI annotation results in a message that clashes visually with the rest of the annotations.See for example https://buildkite.com/automattic/simplenote-ios/builds/1146
Before
After via editing the HTML source in the page. No build run with this yet.
Test
We'll see this in action on the next code freeze.
Review
Only one infrastructure developer required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.