Also checkout release branch in upload release step #1677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I worked on #1675 I decided not to checkout the release branch in the upload step because I thought "it's just downloading the artifact and sending it to ASC, we have it in a dedicated step just so if the upload fails we don't need to re-run the whole build process."
Alas, I had forgotten that step also uploads the dSYM to Sentry and creates the GitHub release. (The name
upload_to_testflight
doesn't help remembering it).When the release is created, the automation reads the version from the codebase, meaning we need to be on the latest commit. Otherwise, we'll do like in the last build where we uploaded 4.55.0.2 to TestFlight but created a release named 4.55.0.1 (since then deleted)