Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also checkout release branch in upload release step #1677

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Oct 30, 2024

When I worked on #1675 I decided not to checkout the release branch in the upload step because I thought "it's just downloading the artifact and sending it to ASC, we have it in a dedicated step just so if the upload fails we don't need to re-run the whole build process."

Alas, I had forgotten that step also uploads the dSYM to Sentry and creates the GitHub release. (The name upload_to_testflight doesn't help remembering it).

When the release is created, the automation reads the version from the codebase, meaning we need to be on the latest commit. Otherwise, we'll do like in the last build where we uploaded 4.55.0.2 to TestFlight but created a release named 4.55.0.1 (since then deleted)

image

@mokagio
Copy link
Contributor Author

mokagio commented Oct 30, 2024

Bypassing CI checks because this change does not run in the standard CI pipeline. We'll validate it next by retrying the complete code freeze pipeline. Same as #1669, #1675, etc.

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 30, 2024

1 Message
📖 This PR has the Releases label: some checks will be skipped.

Generated by 🚫 Danger

@mokagio mokagio merged commit c4af0f3 into release/4.55 Oct 30, 2024
3 of 9 checks passed
@mokagio mokagio deleted the mokagio/also-checkout-release-b-in-upload branch October 30, 2024 19:21
@mokagio mokagio added this to the 4.55 ❄️ milestone Oct 30, 2024
@mokagio mokagio added tooling Related to anything that supports the building & maintaining of the project. Releases labels Oct 30, 2024
@wpmobilebot
Copy link
Collaborator

Simplenote Prototype Build📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build Simplenote Prototype Build
Build Numberpr1677-16544b0-0192dedf-f092-4c10-b381-1ba1e51d6614
Version4.55
Bundle IDcom.codality.NotationalFlow.Alpha
Commit16544b0
App Center BuildSimplenote - Installable Builds #402
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Releases tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants