[Tooling] Update CI image from xcode-16.1-rc.1 to xcode-16.1-v4
#1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencertransier
added
the
tooling
|
| App Name |  Simplenote Prototype Build |
|
| Build Number | pr1686-0ecc10d-0193470b-93b5-4341-89fe-a80d65fdb2c6 | |
| Version | 4.55 | |
| Bundle ID | com.codality.NotationalFlow.Alpha | |
| Commit | 0ecc10d | |
| App Center Build | Simplenote - Installable Builds #412 |
AliSoftware
approved these changes
Nov 19, 2024
.buildkite/shared-pipeline-vars
Outdated
Comment on lines
7
to
11
| XCODE_VERSION=$(sed -E -n 's/^(~> )?(.*)/xcode-\2/p' .xcode-version) | ||
| export CI_TOOLKIT_PLUGIN_VERSION="3.4.2" | ||
| export CI_TOOLKIT_PLUGIN_VERSION="3.7.1" | ||
|
|
||
| export IMAGE_ID="$XCODE_VERSION" | ||
| # Note: `-v4` suffix was added to use xcode-16.1-v4 image; remember to remove that suffix during the next Xcode update | ||
| export IMAGE_ID="$XCODE_VERSION-v4" |
There was a problem hiding this comment.
💄 Nitpick: in most other repos we insert the xcode- prefix during the export IMAGE_ID= instead of via the sed, i.e.:
XCODE_VERSION=$(sed -E 's/^~> ?//' .xcode-version)
…
export IMAGE_ID="xcode-$XCODE_VERSION-v4"This not only makes the sed command simpler (and thus more readable), but it also better matches the variable names. Indeed, with that approach XCODE_VERSION contains just the Xcode version itself, without the xcode- prefix. And it's only when assigning the IMAGE_ID value that we add the xcode- prefix because that's how we name our VM images.
There was a problem hiding this comment.
Updated in 0ecc10d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This updates the CI image from
xcode-16.1-rc.1toxcode-16.1.v4. The original 16.1 image only had 92GB of space. The v4 image was upgraded to use 120GB instead.It also updates the CI Toolkit from
3.4.2to3.7.1.How to test
Good to go as long as CI is green.