Refactored showing note window to clarify and remove a warning

Automattic · Apr 12, 2024 · 17c311d · 17c311d
1 parent f87f00f
commit 17c311d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Simplenote/NoteListViewController.swift b/Simplenote/NoteListViewController.swift
@@ -875,11 +875,14 @@ extension NoteListViewController {
         guard let note = listController.note(at: tableView.selectedRow) else {
             return
         }
+
         let window = NoteWindow()
         let windowController = NSWindowController(window: window)
-
         window.show(note)
+        windowController.showWindow(window)
 
+        // We don't want to be able to display the note in more than one editor at a time
+        // So when double tapped we open into a new window and close the editor in the main window
         tableView.deselectRow(tableView.selectedRow)
         refreshPresentedNote()
     }

diff --git a/Simplenote/NoteWindow.swift b/Simplenote/NoteWindow.swift
@@ -36,7 +36,5 @@ class NoteWindow: NSWindow {
         editor.toolbarView.sidebarButton.isHidden = true
         editor.displayNote(note)
         title = note.titlePreview
-
-        windowController?.showWindow(self)
     }
 }