Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Electron Forge to version 7.3.1 #201

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jun 3, 2024

This PR is a follow-up of #198 to address a failure on Windows when generating the builds (#135 (comment)).

Proposed Changes

  • Downgrade Electron Forge packages to version 7.3.1 to avoid using the version >= 18.2.0 of the packageelectron/packager. This is mainly to avoid this change in version 7.4.0 that requires that build versions are in number format (e.g. a.b.c.d).

Testing Instructions

  • Observe that all CI jobs pass.
  • Observe that builds work as expected in the different architectures.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@fluiddot fluiddot requested review from wojtekn and a team June 3, 2024 10:54
@fluiddot fluiddot self-assigned this Jun 3, 2024
"@electron-forge/maker-zip": "^7.4.0",
"@electron-forge/plugin-auto-unpack-natives": "^7.4.0",
"@electron-forge/plugin-webpack": "^7.4.0",
"@electron-forge/cli": "7.3.1",
Copy link
Contributor Author

@fluiddot fluiddot Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I removed ^ from the version to avoid upgrading it to the minor version 7.4.0. If we'd like to allow upgrading to a patch version we could replace it with ~.

Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@fluiddot
Copy link
Contributor Author

fluiddot commented Jun 3, 2024

The Windows builds are failing due to the version format. I noticed that the package-lock.json still has references to the version that we want to avoid of @electron/forge package 18.2.0+. I'll update the dependencies configuration to ensure that version 18.1.3 is always installed.

UPDATE: Workaround applied in 58fce2f.

@fluiddot fluiddot merged commit 8fc3a5d into trunk Jun 3, 2024
11 checks passed
@fluiddot fluiddot deleted the update/downgrade-electron-forge-7.3.1 branch June 3, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants