Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting text to include br and code tags #144

Merged
merged 2 commits into from
May 8, 2020

Conversation

gikaragia
Copy link
Contributor

Overview

There was an issue in the 'Load All Brushes' setting where HTML tags were displayed to the user.

With this fix code and br tags are not escaped. Additionally line breaks and spaces were removed (br tags are still allowed to not break translations that potentually use it)

Testing instructions

  • Navigate to the plugins settings page.
  • Observe that the text in the 'Load All Brushes' setting is displayed correctly.

@gikaragia gikaragia requested a review from jom April 28, 2020 13:18
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well! One minor change.

syntaxhighlighter.php Outdated Show resolved Hide resolved
@gikaragia gikaragia requested a review from jom May 8, 2020 07:33
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gikaragia gikaragia merged commit 8d4c3e9 into master May 8, 2020
@gikaragia gikaragia deleted the fix/load-all-bruses branch May 8, 2020 07:47
@alexsanford alexsanford added this to the v3.5.5 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants