Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor block JS code #171

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Refactor block JS code #171

merged 3 commits into from
Dec 17, 2020

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Nov 13, 2020

Refactor the plugin's block editor code to make it easier to work with.

Changes proposed:

  • Break up block definition into multiple files
  • Update syntax & formatting
  • Update block setting items to JSX syntax

Testing instructions:

  • Open or create a post with a SyntaxHighlighter Code block
  • Make sure it works in the editor & frontend, including various settings

@yscik yscik added this to the v3.6.0 milestone Nov 13, 2020
@yscik yscik requested a review from jom November 13, 2020 15:58
@yscik yscik mentioned this pull request Nov 17, 2020
Merged
jom
jom approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and still works.

Eventually we should change "esversion": 3, -> 6 in .jshintrc. I'm getting lots of warnings.

@yscik yscik merged commit 3fbdbd1 into master Dec 17, 2020
@yscik yscik deleted the change/refactor-block branch December 17, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jom jom jom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yscik @jom