Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the list of available brushes #221

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Display the list of available brushes #221

merged 3 commits into from
Nov 19, 2021

Conversation

merkushin
Copy link
Member

@merkushin merkushin commented Nov 15, 2021 •
edited
Loading

These brushes could be used as shortcodes instead of passing them to lang property.

Previously, this list was available on the external website but now is not reachable anymore.

Fixes #207

Changes proposed in this Pull Request

  • Remove external link (the website redirects to another project now).
  • Add a list of available tags.

Testing instructions

  • Install and activate SyntaxHighlighter Evolved.
  • Go to Settings -> SyntaxHighlighter.
  • Find Shortcode Parameters.

Screenshot / Video

Before:
CleanShot 2021-11-15 at 13 59 19@2x

After:
CleanShot 2021-11-15 at 13 52 54@2x

@merkushin merkushin added this to the 3.6.1 milestone Nov 15, 2021
@merkushin merkushin requested a review from renatho November 15, 2021 11:01
@merkushin merkushin self-assigned this Nov 15, 2021
@merkushin
Copy link
Member Author

Hey @renatho! I see Travis-CI checks don't work. Maybe add some GH actions-based checks?

renatho
renatho reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some GH actions-based checks?

Hum! Yep! It would be awesome to make this migration like our other repos. You could create a separate PR since it's not related to this though. ;)

syntaxhighlighter.php Outdated Show resolved Hide resolved
renatho
renatho approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@merkushin
Display the list of available brushes
c4328e9 
These brushes could be used as shortcodes instead of passing them to lang property.

Previously, this list was available on the external website but now is not reachable anymore.
@merkushin
Fix code style
6da3b14
@merkushin
Update comment for translators
b04d4aa
@merkushin merkushin merged commit ebdd9b8 into master Nov 19, 2021
@merkushin merkushin deleted the add/brush-list branch November 19, 2021 16:54
@merkushin merkushin mentioned this pull request Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatho renatho renatho approved these changes

Assignees

@merkushin merkushin

Labels
[Type] Bug
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

Add list of supported tags
2 participants
@merkushin @renatho