Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 Compat: declare class properties #265

Merged
merged 1 commit into from
Nov 22, 2023
Merged

PHP 8 Compat: declare class properties #265

merged 1 commit into from
Nov 22, 2023

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Nov 6, 2023

Fixes #264

Changes proposed in this Pull Request

  • Declaring two class properties

Testing instructions

  • Load the plugin on a site with PHP 8.2 and confirm no depcreation warnings in the error log.

New/Updated Hooks

  • None.

Deprecated Code

  • None.

Screenshot / Video

n/a

thedebian
thedebian approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@thedebian thedebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update

@thedebian thedebian merged commit 2bc9d9b into master Nov 22, 2023
@thedebian thedebian deleted the fix/php8errors branch November 22, 2023 14:40
@fjorgemota fjorgemota mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedebian thedebian thedebian approved these changes

Assignees
No one assigned
Labels
[Pri] Normal [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8 Compat: Creation of dynamic property
2 participants
@kraftbj @thedebian