Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntaxHighlighter: Ensure box sizing accounts for added padding. #278

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Oct 29, 2024

Related to Automattic/themes#8247

Changes proposed in this Pull Request

  • Ensure we're using border-box box-sizing for the SyntaxHighlighter so it doesn't overflow the content container due to added padding.

Testing instructions

  • Visual inspection should suffice.

Screenshot / Video

@sixhours sixhours self-assigned this Oct 29, 2024
@sixhours sixhours changed the title SyntaxHighlighter: Update whitespace styles to allow wrapping SyntaxHighlighter: Update overflow styles to allow scrolling Oct 29, 2024
@sixhours sixhours requested a review from daledupreez November 12, 2024 20:29
@sixhours sixhours requested a review from gavande1 November 13, 2024 15:34
@sixhours sixhours changed the title SyntaxHighlighter: Update overflow styles to allow scrolling SyntaxHighlighter: Ensure box sizing accounts for added padding. Nov 13, 2024
Copy link

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback. I agree with updating box sizing here.

@fjorgemota fjorgemota merged commit 20cffdf into master Nov 25, 2024
@fjorgemota fjorgemota deleted the update/word-wrap branch November 25, 2024 20:25
@fjorgemota fjorgemota mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants