Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet-blocks custom-line-height support opt-in now required. #2265

Closed
Addison-Stavlo opened this issue Jul 16, 2020 · 1 comment · Fixed by #2266
Closed

Seedlet-blocks custom-line-height support opt-in now required. #2265

Addison-Stavlo opened this issue Jul 16, 2020 · 1 comment · Fixed by #2266

Comments

@Addison-Stavlo
Copy link
Contributor

I ran into this change while working on some FSE blocks and testing with the Seedlet-Blocks theme. Perhaps this is already on your radar but I figured it would be worth a heads-up. (@kjellr - I hope you don't mind but since you authored the Seedlet p2 post I figured you would be the right person to ping.)

Steps to replicate

  • Run Gutenberg master with seedlet blocks theme.
  • In the editor select a post and look to customize the Line Height.
  • Verify this option is no longer available.

Recent changes in Gutenberg have made the block level custom line hight options require a theme level opt-in. That is, the "Line Height" option we used to have for blocks such as Paragraph:

Screen Shot 2020-07-16 at 2 28 57 PM

Is no longer present on Gutenberg master while using Seedlet Blocks. For this to be available again, we will need to add add_theme_support( 'custom-line-height' ) to the theme (WordPress/gutenberg#23044 (comment)).

@kjellr
Copy link
Contributor

kjellr commented Jul 16, 2020

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants