Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seedlet: Opt in to line custom-line-height #2266

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Seedlet: Opt in to line custom-line-height #2266

merged 1 commit into from
Jul 17, 2020

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Jul 16, 2020

Fixes #2265. Seedlet already supports this, but custom line height has turned into an opt-in rather than a default.

Before:

Screen Shot 2020-07-16 at 6 42 46 PM

After:

Screen Shot 2020-07-16 at 6 21 39 PM

@kjellr kjellr added [Type] Bug Something isn't working [Theme] Seedlet labels Jul 16, 2020
@kjellr kjellr self-assigned this Jul 16, 2020
@jffng jffng merged commit 0bff9da into master Jul 17, 2020
@jffng
Copy link
Contributor

jffng commented Jul 17, 2020

Side note — it feels like theme authors will have two ways of controlling the editor and site appearance — via theme.json and add_theme_support.

@kjellr kjellr deleted the seedlet/add/line-height-theme-support branch July 20, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jffng jffng jffng approved these changes

@allancole allancole Awaiting requested review from allancole

@Addison-Stavlo Addison-Stavlo Awaiting requested review from Addison-Stavlo

Assignees

@kjellr kjellr

Labels
[Theme] Seedlet [Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seedlet-blocks custom-line-height support opt-in now required.
2 participants
@kjellr @jffng