Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User-Configurable Duotone option to Customizer #4434

Closed
pbking opened this issue Aug 17, 2021 · 3 comments
Closed

Add User-Configurable Duotone option to Customizer #4434

pbking opened this issue Aug 17, 2021 · 3 comments
Assignees
Labels
[Theme] Skatepark Automatically generated label for Skatepark.
Milestone

Comments

@pbking
Copy link
Contributor

pbking commented Aug 17, 2021

So that a user can control the Global Duotone options they should be presented with an option to enable/disable the duotone usage on all of the images.

  • Enabling it applies the primary/background colors to the duotone attribute of all relevant blocks.
  • Disabling it removes all colors from the duotone attribute of all relevant blocks.
  • When a user changes Primary/Background colors using the customizer (and the option is enabled) those Primary/Background colors should be applied to all relevant blocks' duotone attributes. (Note: If we are able to accomplish this issue then this item can be simplified by just using the --primary and --background CSS variables.)
  • Determining if the control is enabled or disabled should be done comparing values in the User Theme JSON rather than via theme_mod values.

The "FSE" equivalent will be to manually set the duotone values of the blocks in question in the FSE Global Styles panel.

@pbking pbking added this to the Skatepark milestone Aug 17, 2021
@pbking pbking added the [Theme] Skatepark Automatically generated label for Skatepark. label Aug 17, 2021
@pbking
Copy link
Contributor Author

pbking commented Aug 17, 2021

This will MOST LIKELY be accomplished by adjusting the User Theme JSON block styles of all of the image blocks to have the same values of color.duotone as primary and background.

@pbking pbking changed the title Add User-Configurable Duo-tone options to Customizer Add User-Configurable Duotone options to Customizer Aug 17, 2021
@pbking pbking changed the title Add User-Configurable Duotone options to Customizer Add User-Configurable Duotone option to Customizer Aug 17, 2021
@MaggieCabrera
Copy link
Contributor

I'm totally onboard with Global Styles booleans, wish we could have them! This looks like a good approach to me

@MaggieCabrera
Copy link
Contributor

This one isn't actually closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Skatepark Automatically generated label for Skatepark.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants