Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skatepark: Duotone theme-level configuration #4329

Closed
MaggieCabrera opened this issue Jul 26, 2021 · 4 comments
Closed

Skatepark: Duotone theme-level configuration #4329

MaggieCabrera opened this issue Jul 26, 2021 · 4 comments
Labels
[Theme] Skatepark Automatically generated label for Skatepark.
Milestone

Comments

@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Jul 26, 2021

Skatepark includes in its design the application of duotone filter on the images it provides. The theme should apply this filter to all relevant blocks by default.

This will require WordPress/gutenberg#33642 to be addressed, which will allow us to set a filter as default (and we should consider changing the default filter when the user changes the theme color as well).

@MaggieCabrera MaggieCabrera added the [Theme] Skatepark Automatically generated label for Skatepark. label Jul 26, 2021
@MaggieCabrera MaggieCabrera added this to the Skatepark milestone Jul 26, 2021
@MaggieCabrera MaggieCabrera changed the title Skatepark: Duotone Skatepark: Duotone supports Jul 26, 2021
@MaggieCabrera MaggieCabrera self-assigned this Aug 5, 2021
@MaggieCabrera
Copy link
Contributor Author

Duotone apparently doesn't support css variables, so I'm looking into it to see if I can submit a patch for it

@MaggieCabrera
Copy link
Contributor Author

Apparently it's not trivial to make the duotone filters dynamic, so I opened an issue about it on GB and contacted the devs on top of duotone so that this is on their radar as an enhancement.

@jeffikus
Copy link
Contributor

@MaggieCabrera and I spoke about this, and we're going to pause on this, as it's non blocking. For v1, the customer can make changes in the editor, but changing the global colors won't apply to all instances of the block. We can overcome this initially with head start and patterns, and this can be improved in the block in future.

@pbking
Copy link
Contributor

pbking commented Aug 17, 2021

Added this to track allowing a user to control the application of duotone to all blocks.

@pbking pbking changed the title Skatepark: Duotone supports Skatepark: Duotone theme-level configuration Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Skatepark Automatically generated label for Skatepark.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants