Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skatepark: created duotone presets #4388

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Skatepark: created duotone presets #4388

merged 1 commit into from
Aug 11, 2021

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Aug 11, 2021

Changes proposed in this Pull Request:

After talking with @jeffikus we thought that the best course of action for the moment is to provide the presets for all the alternative palettes on the filter so that the user can change their images manually until a solution for WordPress/gutenberg#33905 is applied and we can have dynamic filters. This PR adds filters for all the palettes in the theme:

Screenshot 2021-08-11 at 12 07 15

Screenshot 2021-08-11 at 12-03-50 Test duotone – free

Related issue(s):

#4329

@MaggieCabrera MaggieCabrera requested review from melchoyce and a team August 11, 2021 10:08
@MaggieCabrera MaggieCabrera added the [Theme] Skatepark Automatically generated label for Skatepark. label Aug 11, 2021
@MaggieCabrera MaggieCabrera self-assigned this Aug 11, 2021
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from a technical perspective, these look and work great on my local install and sandbox 👍

Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and looks good! Thanks

@MaggieCabrera MaggieCabrera merged commit ea346dd into trunk Aug 11, 2021
@MaggieCabrera MaggieCabrera deleted the duotone-presets branch August 11, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Skatepark Automatically generated label for Skatepark.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants