Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duotone filter: Allow theme.json to set default filters for blocks #33642

Closed
MaggieCabrera opened this issue Jul 23, 2021 · 0 comments · Fixed by #34667
Closed

Duotone filter: Allow theme.json to set default filters for blocks #33642

MaggieCabrera opened this issue Jul 23, 2021 · 0 comments · Fixed by #34667
Assignees
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Image Affects the Image Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@MaggieCabrera
Copy link
Contributor

What problem does this address?

It would be great to have the option to set a default duotone filter for the blocks from within the theme. That would allow theme authors to fit the images/media on the site to fit with the color scheme of the theme.

What is your proposed solution?

Something like this on theme.json would be nice to have:

"styles": {
    "blocks": {
        "core/image": {
            "color": {
                "duotone": "my-duotone-slug"
            }
        }
    }
}

@ajlende

@MaggieCabrera MaggieCabrera added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Image Affects the Image Block labels Jul 23, 2021
@mtias mtias added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Jul 23, 2021
@ajlende ajlende self-assigned this Aug 16, 2021
@mtias mtias mentioned this issue Sep 6, 2021
16 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Image Affects the Image Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants