Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet: Fix for hover state on outline buttons #3130

Merged
merged 3 commits into from
Jan 29, 2021

Conversation

MaggieCabrera
Copy link
Contributor

Changes proposed in this Pull Request:

This PR removes hover effects on outlined buttons that don't have the secondary color.

Related issue(s):

#3110

@MaggieCabrera MaggieCabrera requested a review from kjellr January 28, 2021 15:42
@MaggieCabrera MaggieCabrera self-assigned this Jan 28, 2021
@scruffian scruffian changed the title Seedlet: Fix for hover state on noutline buttons Seedlet: Fix for hover state on outline buttons Jan 28, 2021
@kjellr
Copy link
Contributor

kjellr commented Jan 28, 2021

This is much closer! The only issue I'm seeing is with outlined buttons that have a background color applied. It looks like in that case, the background colors aren't being picked up in the front end:

Editor Front End
Screen Shot 2021-01-28 at 10 48 31 AM Screen Shot 2021-01-28 at 10 48 15 AM

@MaggieCabrera
Copy link
Contributor Author

This is much closer! The only issue I'm seeing is with outlined buttons that have a background color applied. It looks like in that case, the background colors aren't being picked up in the front end

Thank you Kjell, you are so thorough :)

I think this should be fixed now.

Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well in my testing. Thank you!

@MaggieCabrera MaggieCabrera merged commit 2c4836a into trunk Jan 29, 2021
@MaggieCabrera MaggieCabrera deleted the fix/seedlet/hover-buttons-outline branch January 29, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants