Add Navigation styling to BCB #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
reviewed
Mar 15, 2021
jffng
reviewed
Mar 16, 2021
… submenu as an option.
…ion blocks in the header.
code formatting improvement Co-authored-by: Jeff Ong <jeff.ong@automattic.com>
pbking
force-pushed
the
add/bcb-navigation
branch
from
18baa5e
to
7b4728a
Compare
jffng
approved these changes
Mar 16, 2021
| menuContainer.scrollTop = 0; | ||
| if( 0 === clickEvent.detail) { | ||
| // Menu was opened with keyboard, apply focus to close button. | ||
| menuContainer.querySelector('button:first-of-type')?.focus(); |
There was a problem hiding this comment.
To confirm, we can use optional chaining (?.) because we are not supporting IE, correct?
There was a problem hiding this comment.
Oh, man, force of habit. Previously I ran all JS code through Babel to transpile it for IE.
None of this would work in IE though since it's so dependent on CSS Variables. Easy enough to add a null check instead though in case the CSS vars polyfill can do the trick here.
There was a problem hiding this comment.
Refactored out the cool stuff.
Replaced with boring 'ol null checks.
remove log Co-authored-by: Jeff Ong <jeff.ong@automattic.com>
code formatting Co-authored-by: Jeff Ong <jeff.ong@automattic.com>
Code nicificiation. Co-authored-by: Jeff Ong <jeff.ong@automattic.com>
Code nicificiation. Co-authored-by: Jeff Ong <jeff.ong@automattic.com>
|
This (mobile) shim can be replaced when WordPress/gutenberg#22824 is completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just adds configuration to the already-present navigation styles.
You'll have to add the navigation elements in FSE for this to show up.
This change also adds the drop shadow setting to match existing Blank Canvas style.
Additionally any
core/navigationblock that is in a<header>will receive "mobile" styling.To support mobile styling quite a few additional custom styles have been added under
custom.navigation.mobile.Additionally javascript is loaded to support that menu by adding the button that opens the mobile menu. It's as small an amount of JavaScript as I could add and still be functional simply creating two buttons - open and close - and labeling them based on CSS variables which add/remove a
showclass to the menu block.