-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quadrat: revise post header and meta #3824
Conversation
<!-- wp:post-date {"textAlign":"center","fontSize":"tiny"} /--> | ||
<!-- wp:post-tags {"textAlign":"center","fontSize":"tiny"} /--> | ||
<!-- wp:spacer --> | ||
<div style="height:170px" aria-hidden="true" class="wp-block-spacer"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it better to use padding on the group block? even margin now that we can do that? I'm writing this but I think I prefer spacers when the distance is so prominent so feel free to ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, for some reason using spacers feels a bit nicer when the spacing is large and opinionated like this. It makes the design more explicit via blocks.
@@ -199,9 +199,9 @@ | |||
}, | |||
"core/post-title": { | |||
"typography": { | |||
"fontSize": "min(max(36px, 5vw), 65px)", | |||
"fontSize": "min(max(48px, 7vw), 80px)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the same we are using for h1, should we make a variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, perhaps. I will look at adding one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me in terms of code
That's weird! Can we adjust using CSS in the meantime? |
It looks like the divider is output in raw HTML (no wrapping or pseudo element), so I can't target / change its contents with CSS: I will look at submitting an improvement in Gutenberg (EDIT: opened an issue here WordPress/gutenberg#31710). In the meantime, is the rest of this PR okay to you? I also just realized the way I'm adding the dot in between the date isn't good because it will always display, even if the post has no categories. So I will change that. |
While that issue gets sorted out, can you do something like this pseudocode to hide the pipes?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Kjell Reigstad <kjell.reigstad@automattic.com>
Co-authored-by: Kjell Reigstad <kjell.reigstad@automattic.com>
Co-authored-by: Kjell Reigstad <kjell.reigstad@automattic.com>
This PR addresses #3784.
One thing I wasn't able to address is changing the divider between categories. This is baked into the block at the moment.