This repository has been archived by the owner on Feb 17, 2025. It is now read-only.
Another attempt at alignments #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
reviewed
Aug 24, 2021
scruffian
reviewed
Aug 24, 2021
|
It would be useful to document the different cases this is trying to address... |
|
They are documented here: pcrugM-lB-p2 |
fix pelling istake Co-authored-by: Ben Dwyer <ben@scruffian.com>
…applying the page-level padding differently.
…hemes into fix/bb-alignments-yet-again
This was referenced Aug 24, 2021
This was referenced Aug 25, 2021
coreymckrill
added a commit
to WordPress/wporg-news-2021
that referenced
this pull request
Sep 9, 2021
This better accommodates the change in Gutenberg that causes all blocks that support `experimentalLayout` (the Group block) to get the `wp-container-[hash]` class added during rendering. See Automattic/themes#4459
coreymckrill
added a commit
to WordPress/wporg-news-2021
that referenced
this pull request
Sep 9, 2021
* Bring over the layout/alignment style changes from Blockbase This better accommodates the change in Gutenberg that causes all blocks that support `experimentalLayout` (the Group block) to get the `wp-container-[hash]` class added during rendering. See Automattic/themes#4459 * Set the post header's layout to flex * Tweak layout styles to restore desired alignments * Avoid using 'important' clauses where possible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP...