Move the paragraph indent style to the first paragraph of every container #4481
Conversation
scruffian
added
the
[Theme] Skatepark
skatepark/sass/base/_text.scss
Outdated
| .wp-block-post-author__content, | ||
| .wp-block-post-comments, | ||
| .wp-block-quote { |
There was a problem hiding this comment.
We might need some more exceptions here.
There was a problem hiding this comment.
having the post comments block inside wp-block-post-content would be weird, would it even work?
There was a problem hiding this comment.
I think cover and media & text also need it...
There was a problem hiding this comment.
having the post comments block inside wp-block-post-content would be weird, would it even work?
It would be weird but it does work. There could be cases where you wanted to encourage comments so you put the form into the post content? If you let people do it, someone will find a use for it!
|
The original issue mentions adding a customizer option to enable/disable this but I don't see how we can translate that to the FSE. Do you think we should add such a setting even if we don't have an FSE counterpart? |
|
I don't think we should add an option for it. |
skatepark/sass/base/_text.scss
Outdated
| } | ||
|
|
||
| .wp-block-post-content { |
There was a problem hiding this comment.
Should we add an .is-root-container selector to target the editor as well?
There was a problem hiding this comment.
I had to use block-editor-writing-flow as is-root-container is also used in the site editor.
There was a problem hiding this comment.
I'm not seeing the indent on the editor right now, I don't see that class on the css of this PR either
|
A few cases I found: Cover block Media + Text I'm not sure if we should remove it or not. I kinda preferred to have an option to add it as a block style for the user and have it off for this block by default. What do you think? Pullquote |
|
I chatted this over with @kjellr. I'm concerned about how complicated this is becoming — either we need a bunch of CSS rules to overwrite the default behavior so it works for all blocks as expected, or we offload the complexity onto users with a block style. I think we should remove the indentation entirely. It was cool to try, and it's a fun aesthetic choice, but unless we can control it natively in Gutenberg we're going to run into lots of edge cases. The theme's color and duotone support should help it stand out even without the indentation. I appreciate all the work y'all did to try this feature out! Maybe we'll be able to implement it natively in the future. |
After Mel's feedback, I removed the custom CSS and left the parts of this PR that were removing the text-indent block styles so we have no indentation anywhere |
|
LGTM 👍 |
Changes proposed in this Pull Request:
This removes the indented block styles, and replaces them with some CSS to target the first paragraph in each container. The CSS is restricted in scope to only within the post content.
To test, try adding all the block patterns to a post.
Related issue(s):
Fixes #4445