Videomaker: Navigation styles #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
the
[Theme] Videomaker
scruffian
reviewed
Oct 20, 2021
scruffian
reviewed
Oct 20, 2021
| @@ -3,6 +3,6 @@ | |||
| <!-- wp:site-logo /--> | |||
| <!-- wp:site-title /--> | |||
| <!-- wp:site-tagline {"style":{"typography":{"fontSize":"var(--wp--custom--font-sizes--tiny)"}}} /--> | |||
| <!-- wp:navigation {"itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","__unstableSocialLinks":"social"} /--> | |||
| <!-- wp:navigation {"className":"is-style-blockbase-navigation-improved-responsive","itemsJustification":"right","isResponsive":true,"__unstableLocation":"primary","__unstableSocialLinks":"social"} /--> | |||
There was a problem hiding this comment.
I added this for testing, but I do think it looks better too. What do you think @kjellr ?
There was a problem hiding this comment.
Yeah, I think this can use the standard block style. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR tweaks the Videomaker navigation styles to match the Figma designs.
It looks like GB doesn't pull through the
current-menu-itemclass, so we're not able to style the active menu item differently at the moment. I've made a change to the navigation attributes PR on GB that fixes this, so it's possible to test on this branch: WordPress/gutenberg#35634.Without the GB PR, I think we'll need to remove the submenu styles. At the moment I've hidden all child menu items unless the parent is the current menu item, which means they'll be hidden by default without the
current-menu-itemclass. Let me know if you want me to remove these now - or maybe comment them out while we wait for a fix?I've made sure the menus in the patterns are still uppercase by adding an inline style to the nav blocks in the patterns.
I've also only styled the responsive menu, as it looks like Videomaker should always use the responsive menu when this can be merged: #4832
Related issue(s):
Closes #4651