Add archeo (as Blockbase child) #5094
Conversation
blockbase/theme.json
Outdated
| "fontSize": "32px" | ||
| "fontSize": "var(--wp--preset--font-size--huge)" |
There was a problem hiding this comment.
is this coming from elsewhere or just a fix?
There was a problem hiding this comment.
It's just a fix. I'll create a separate PR for it.
scruffian
force-pushed
the
add/archeo
branch
from
0b31c67 to
b88ba6b
Compare
|
@kjellr @beafialho would you mind taking a look at this and seeing that else needs to be done? From the top of my head there's:
|
| Theme URI: https://github.com/Automattic/themes/tree/trunk/archeo | ||
| Author: Automattic | ||
| Author URI: https://automattic.com | ||
| Description: A clean portfolio theme |
There was a problem hiding this comment.
We will probably need to update this.
Besides Patterns and Color palettes, have you added the typography styles? I also don't see any Post mockups on Figma (Small Theme V3), do we need those? |
|
This does include the typography styles. We don't have post mockups in the Figma, but it might be easier/quicker to do them directly in this PR. What are the changes needed? |
How's that? I think we may have to iterate a bit on those. |
Whatever is easier for you :) |
|
@scruffian here's the post page for Archeo.
|
|
@beafialho can you include a mockup of when there's no featured image just so that's super clear? I figure the right half of the screen would just be dark gray. |
|
Yes, here's a mockup of when there's no featured image.
|
Changes proposed in this Pull Request:
This is a skeleton version of Archeo:
