Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Club: implementing footer template part #6302

Merged
merged 6 commits into from
Aug 4, 2022
Merged

Club: implementing footer template part #6302

merged 6 commits into from
Aug 4, 2022

Conversation

matiasbenedetto
Copy link
Member

@matiasbenedetto matiasbenedetto commented Jul 29, 2022 •
edited
Loading

Changes proposed in this Pull Request:

Club: implementing footer template part

Related issue(s):

Fixes: #6227

@matiasbenedetto matiasbenedetto added the [Theme] Disco Automatically generated label for Disco, formerly known as Club.. label Jul 29, 2022
madhusudhand
madhusudhand reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove page.html from the commit.
And in general it feels not right to review the template without right typography in place.

@matiasbenedetto matiasbenedetto changed the base branch from trunk to club/page-template August 1, 2022 13:37
@matiasbenedetto matiasbenedetto changed the base branch from club/page-template to trunk August 1, 2022 13:38
@matiasbenedetto
Copy link
Member Author

And in general it feels not right to review the template without right typography in place.

You can just copy theme.json from club/fluid-typography branch and paste it into this branch. Then you will see both changes together.

mikachan
mikachan reviewed Aug 2, 2022
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site title and address paragraph aren't showing as flex columns for me:

image

They look fine in the editor, so I think this is possibly a GB bug:

image

If I force that content to stack on the front end, the layout is working great for me at both larger and smaller resolutions.

club/parts/footer.html Show resolved Hide resolved
@matiasbenedetto
Copy link
Member Author

matiasbenedetto commented Aug 3, 2022 •
edited
Loading

The site title and address paragraph aren't showing as flex columns for me:
They look fine in the editor, so I think this is possibly a GB bug

Yep, it's a Gutenberg bug, I reported it here: WordPress/gutenberg#42938 and submitted a potential fix: WordPress/gutenberg#42939

mikachan
mikachan approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@mikachan mikachan merged commit a1aeeb5 into trunk Aug 4, 2022
@mikachan mikachan deleted the club/footer branch August 4, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

@madhusudhand madhusudhand Awaiting requested review from madhusudhand

Assignees
No one assigned
Labels
[Theme] Disco Automatically generated label for Disco, formerly known as Club..
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

club: Templates: Footer template part
3 participants
@matiasbenedetto @mikachan @madhusudhand