Bute: Update navigation so they are vertically centre to avoid wpcom banners overlapping #7203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
approved these changes
Jul 10, 2023
Remove an extra curly bracket. Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
|
Thanks @mikachan! I opened an issue here: WordPress/gutenberg#52511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This theme suggests having an "always-icon" navigation.
When you open the navigation, the demo or the marketing bars overlap the navigation, and the close button gets hidden.
Usually, this is not a problem because of the z-index of
100000while the banners are99998and99998. However, when a header is inside a cover block, I don't think the z-index is actually100000, thus, it goes underneath the banners :/I thought it'd be best to make the navigation vertically centre to avoid that. There is no option to modify the layout inside the modal, so I needed to use css though.
What do you think? Any other solution that we don't need to hold up the launch?