Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz footer button styles fix #7317

Merged
merged 11 commits into from
Sep 5, 2023

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Aug 16, 2023

Changes proposed in this Pull Request:

  • Fixed secondary button font styles of the quiz template footer

Testing instructions:

Please see Automattic/sensei#7106

Related issue(s):

Automattic/sensei#7073

@Imran92 Imran92 added this to the Course 1.3.3 milestone Aug 16, 2023
@Imran92 Imran92 requested a review from a team August 16, 2023 09:01
@Imran92 Imran92 self-assigned this Aug 16, 2023
Base automatically changed from add/learning-mode-header-nav-styles to feature/frontend-improvements August 18, 2023 12:14
@donnapep donnapep linked an issue Aug 18, 2023 that may be closed by this pull request
Copy link
Contributor

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the font sizes don't quite match the designs, but I still think they look OK. We'll see if anything comes from a review.

@donnapep donnapep merged commit dae44de into feature/frontend-improvements Sep 5, 2023
@donnapep donnapep deleted the add/quiz-footer-lm-styles-fix branch September 5, 2023 17:52
Imran92 added a commit that referenced this pull request Sep 13, 2023
* Course theme: Update the styles of back to lesson button of quiz in learning mode (#7312)

* Fix font weight in gold variation

* Fix back to lesson font family in default variation

* Fix back to lesson font family in gold variation

* Fix back to lesson font family in blue variation

* Fix back to lesson font family in dark variation

* Quiz footer button styles fix (#7317)

* Fix font weight in gold variation

* Fix back to lesson font family in default variation

* Fix back to lesson font family in gold variation

* Fix back to lesson font family in blue variation

* Fix back to lesson font family in dark variation

* Fix default font size

* Fix gold variation font size

* Fix dark variation font size

* Fix blue variation font size

* Simply Quiz Actions block CSS

---------

Co-authored-by: Donna Peplinskie <donnapep@gmail.com>

* Update stylings for quiz, questions and answers (#7331)

* Fix font weight in gold variation

* Fix back to lesson font family in default variation

* Fix back to lesson font family in gold variation

* Fix back to lesson font family in blue variation

* Fix back to lesson font family in dark variation

* Fix default font size

* Fix gold variation font size

* Fix dark variation font size

* Fix blue variation font size

* Fix default variation question title font stylings

* Fix spacings above and below question title

* Add default style for file upload button

* Add question, title and file upload button styles for blue variation

* Add question, title and file upload button styles for dark variation

* Add question, title and file upload button styles for gold variation

* Update file upload placeholder spacings for all variations

* Further clarify CSS selector to prevent collisions

* Adjust question title CSS for Gold variation

* Set font family for quiz points in Gold variation

* Eliminate use of custom font size

* Remove obsolete CSS for file upload component

---------

Co-authored-by: Donna Peplinskie <donnapep@gmail.com>

---------

Co-authored-by: Imran Hossain <imran.hossain@automattic.com>
Co-authored-by: Donna Peplinskie <donnapep@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update quiz footer in Learning Mode
2 participants