-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz footer button styles fix #7317
Merged
donnapep
merged 11 commits into
feature/frontend-improvements
from
add/quiz-footer-lm-styles-fix
Sep 5, 2023
Merged
Quiz footer button styles fix #7317
donnapep
merged 11 commits into
feature/frontend-improvements
from
add/quiz-footer-lm-styles-fix
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Base automatically changed from
add/learning-mode-header-nav-styles
to
feature/frontend-improvements
August 18, 2023 12:14
donnapep
approved these changes
Sep 5, 2023
donnapep
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the font sizes don't quite match the designs, but I still think they look OK. We'll see if anything comes from a review.
Imran92
added a commit
that referenced
this pull request
Sep 13, 2023
* Course theme: Update the styles of back to lesson button of quiz in learning mode (#7312) * Fix font weight in gold variation * Fix back to lesson font family in default variation * Fix back to lesson font family in gold variation * Fix back to lesson font family in blue variation * Fix back to lesson font family in dark variation * Quiz footer button styles fix (#7317) * Fix font weight in gold variation * Fix back to lesson font family in default variation * Fix back to lesson font family in gold variation * Fix back to lesson font family in blue variation * Fix back to lesson font family in dark variation * Fix default font size * Fix gold variation font size * Fix dark variation font size * Fix blue variation font size * Simply Quiz Actions block CSS --------- Co-authored-by: Donna Peplinskie <donnapep@gmail.com> * Update stylings for quiz, questions and answers (#7331) * Fix font weight in gold variation * Fix back to lesson font family in default variation * Fix back to lesson font family in gold variation * Fix back to lesson font family in blue variation * Fix back to lesson font family in dark variation * Fix default font size * Fix gold variation font size * Fix dark variation font size * Fix blue variation font size * Fix default variation question title font stylings * Fix spacings above and below question title * Add default style for file upload button * Add question, title and file upload button styles for blue variation * Add question, title and file upload button styles for dark variation * Add question, title and file upload button styles for gold variation * Update file upload placeholder spacings for all variations * Further clarify CSS selector to prevent collisions * Adjust question title CSS for Gold variation * Set font family for quiz points in Gold variation * Eliminate use of custom font size * Remove obsolete CSS for file upload component --------- Co-authored-by: Donna Peplinskie <donnapep@gmail.com> --------- Co-authored-by: Imran Hossain <imran.hossain@automattic.com> Co-authored-by: Donna Peplinskie <donnapep@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Testing instructions:
Please see Automattic/sensei#7106
Related issue(s):
Automattic/sensei#7073