Remove legacy Learning Mode CSS as it's part of Sensei now #7431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
renatho
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Update styles of question feedback (#7373) * Specify the grade style to be applied only in the question header * Update background color for gold variation * Update background color for default variation * Update border color for gold variation * Tweak CSS formatting * Tweak color for border of ordering question --------- Co-authored-by: Donna Peplinskie <donnapep@gmail.com> * Update version and description * Add new changelog * Remove legacy Learning Mode CSS as it's part of Sensei now (#7431) * Course: Add body class for theme variations (#7432) * Add custom property with variation name * Add function to add body class and enqueue proper stylesheets * Add stylesheets for all variations * Add version number * Style the "Awaiting Grade" notice (#7401) * Style "Awaiting Grade" notice * Move custom CSS to other areas of theme.json * Remove typography setting as it needs to be done via CSS * Do the same for the variations * Fix notice style getting broken for css parsing issue --------- Co-authored-by: Imran Hossain <imranh920@gmail.com> * Bump versions and update change log --------- Co-authored-by: Imran Hossain <imranh920@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7429.
Changes proposed in this Pull Request:
Removes the
learning-mode.cssfile as it's part of Sensei now and users have had plenty of time to update both the plugin and the theme. We also want to try to minimize the use of Sensei-specific code in the theme, and instead have it in Sensei where possible.Testing Instructions